resolve path to localize-translate script and execute the script directly
#929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ValentinBossi
commented
Aug 26, 2025
| @@ -76,7 +76,9 @@ export async function translateFederationArtefacts( | |||
|
|
|||
| const sourceLocalePath = path.join(outputPath, 'browser', sourceLocale); | |||
|
|
|||
| const cmd = `node node_modules/.bin/localize-translate -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`; | |||
There was a problem hiding this comment.
here executing execSync("node node_modules/.bin/localize-translate ... ") where "localize-translate" contains
@ECHO off
GOTO start
:find_dp0
SET dp0=%~dp0
EXIT /b
:start
SETLOCAL
CALL :find_dp0
IF EXIST "%dp0%\node.exe" (
SET "_prog=%dp0%\node.exe"
) ELSE (
SET "_prog=node"
SET PATHEXT=%PATHEXT:;.JS;=;%
)
endLocal & goto #_undefined_# 2>NUL || title %COMSPEC% & "%_prog%" "%dp0%\..\@angular\localize\tools\bundles\src\translate\cli.js" %*
does not make much sense, no? we execute it a bit node wrapped, something like node node translate -args i guess.
ValentinBossi
commented
Aug 26, 2025
| const cmd = `node node_modules/.bin/localize-translate -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`; | ||
| const localizeTranslate = path.resolve("node_modules/.bin/localize-translate"); | ||
|
|
||
| const cmd = `${localizeTranslate} -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`; |
There was a problem hiding this comment.
also just removing "node" in the cmd makes some trouble so i use path.resolve().
this code is tested and runs on windows 11 and on gitpod with a linux.
2 tasks
ValentinBossi
changed the title
localize-translate script and execute the script directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #879